-
Notifications
You must be signed in to change notification settings - Fork 18
feat: introducing watsonx sql database wrapper and toolkit #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
||
from langchain_core.caches import BaseCache as BaseCache | ||
from langchain_core.callbacks import Callbacks as Callbacks | ||
from langchain_core.language_models import BaseLanguageModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we are importing BaseCache
as BaseCache
etc. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No needed, removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The goal of this PR is to add
WatsonxSQLDatabase
andWatsonxSQLDatabaseToolkit
to langchain_ibm.Example